i2c: move i2c_omap's probe function to .devinit.text
authorUwe Kleine-König <[email protected]>
Thu, 4 Feb 2010 19:56:53 +0000 (20:56 +0100)
committerGreg Kroah-Hartman <[email protected]>
Mon, 8 Mar 2010 01:04:50 +0000 (17:04 -0800)
A pointer to omap_i2c_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <[email protected]>
Cc: Kalle Jokiniemi <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: Paul Walmsley <[email protected]>
Cc: Richard Woodruff <[email protected]>
Cc: chandra shekhar <[email protected]>
Cc: Jason P Marini <[email protected]>
Cc: Syed Mohammed Khasim <[email protected]>
Cc: Jarkko Nikula <[email protected]>
Cc: Juha Yrjola <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
drivers/i2c/busses/i2c-omap.c

index 913abd7c172fa4c5b8a05840636c6700d4e1fbbf..c7c237537f8147d8ff72cd8d7b5eee692cbb8fbe 100644 (file)
@@ -850,7 +850,7 @@ static const struct i2c_algorithm omap_i2c_algo = {
        .functionality  = omap_i2c_func,
 };
 
-static int __init
+static int __devinit
 omap_i2c_probe(struct platform_device *pdev)
 {
        struct omap_i2c_dev     *dev;