media: cec: set ev rather than v with CEC_PIN_EVENT_FL_DROPPED bit

Setting v with the CEC_PIN_EVENT_FL_DROPPED is incorrect, instead
ev should be set with this bit. Fix this.

Detected by CoverityScan, CID#1467974 ("Extra high-order bits")

Fixes: 6ec1cbf6b125 ("media: cec: improve CEC pin event handling")
Signed-off-by: Colin Ian King <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>

diff --git a/drivers/media/cec/cec-pin.c b/drivers/media/cec/cec-pin.c
index 2a5df99735fa27cc2a260da565357ce5cb45d80f..6e311424f0dc5030ab33571bdb9a4d4958093cdd 100644 (file)
--- a/drivers/media/cec/cec-pin.c
+++ b/drivers/media/cec/cec-pin.c
@@ -119,7 +119,7 @@ static void cec_pin_update(struct cec_pin *pin, bool v, bool force)
 
                if (pin->work_pin_events_dropped) {
                        pin->work_pin_events_dropped = false;
-                       v |= CEC_PIN_EVENT_FL_DROPPED;
+                       ev |= CEC_PIN_EVENT_FL_DROPPED;
                }
                pin->work_pin_events[pin->work_pin_events_wr] = ev;
                pin->work_pin_ts[pin->work_pin_events_wr] = ktime_get();