lightnvm: pblk: fix resource leak of invalid_bitmap

Currently the error exit path when the emeta could not be
interpreted is via fail_free_ws and this fails to free
invalid_bitmap.  Fix this by adding another exit label and
exiting via this to kfree invalid_bitmap.

Detected by CoverityScan, CID#1469659 ("Resource leak")

Fixes: 48b8d20895f8 ("lightnvm: pblk: garbage collect lines with failed writes")
Signed-off-by: Colin Ian King <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>

diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
index df88f1bdd921fdab3644e4c23e46c75b5c600daf..6a4883e40cc0fa7bbb40756b873ff86c1d94be11 100644 (file)
--- a/drivers/lightnvm/pblk-gc.c
+++ b/drivers/lightnvm/pblk-gc.c
@@ -203,7 +203,7 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work)
                if (!lba_list) {
                        pr_err("pblk: could not interpret emeta (line %d)\n",
                                        line->id);
-                       goto fail_free_ws;
+                       goto fail_free_invalid_bitmap;
                }
        }
 
@@ -280,6 +280,7 @@ fail_free_gc_rq:
        kfree(gc_rq);
 fail_free_lba_list:
        pblk_mfree(lba_list, l_mg->emeta_alloc_type);
+fail_free_invalid_bitmap:
        kfree(invalid_bitmap);
 fail_free_ws:
        kfree(line_ws);