sctp: remove a redundant NULL check

It confuses Smatch when we check "sinit" for NULL and then non-NULL and
that causes a false positive warning later.

Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Neil Horman <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 7cc62b922f122aaf949e9c1e7ac0b8c2718785e1..6b20a15678f67514a020f866b53f47791db2a6b1 100644 (file)
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -1743,7 +1743,7 @@ static int sctp_sendmsg(struct kiocb *iocb, struct sock *sk,
                 * either the default or the user specified stream counts.
                 */
                if (sinfo) {
-                       if (!sinit || (sinit && !sinit->sinit_num_ostreams)) {
+                       if (!sinit || !sinit->sinit_num_ostreams) {
                                /* Check against the defaults. */
                                if (sinfo->sinfo_stream >=
                                    sp->initmsg.sinit_num_ostreams) {