projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
41cc304
)
irqchip/exiu: Fix return value check in exiu_init()
author
Wei Yongjun
<
[email protected]
>
Tue, 14 Nov 2017 06:57:28 +0000
(06:57 +0000)
committer
Thomas Gleixner
<
[email protected]
>
Tue, 14 Nov 2017 10:27:22 +0000
(11:27 +0100)
In case of error, the function of_iomap() returns NULL pointer not
ERR_PTR().
Replace the IS_ERR() test of the return value with NULL test and return
a proper error code.
Fixes: 706cffc1b912 ("irqchip/exiu: Add support for Socionext Synquacer EXIU controller")
Signed-off-by: Wei Yongjun <
[email protected]
>
Signed-off-by: Thomas Gleixner <
[email protected]
>
Acked-by: Ard Biesheuvel <
[email protected]
>
Cc: Marc Zyngier <
[email protected]
>
Cc: Jason Cooper <
[email protected]
>
Link:
https://lkml.kernel.org/r/
[email protected]
drivers/irqchip/irq-sni-exiu.c
patch
|
blob
|
history
diff --git
a/drivers/irqchip/irq-sni-exiu.c
b/drivers/irqchip/irq-sni-exiu.c
index 1b6e2f7c59af67ba5e3bdbf1d2387e85ccee1d56..1927b2f36ff6e5e760fce6bd7b5776c51ff9179b 100644
(file)
--- a/
drivers/irqchip/irq-sni-exiu.c
+++ b/
drivers/irqchip/irq-sni-exiu.c
@@
-196,8
+196,8
@@
static int __init exiu_init(struct device_node *node,
}
data->base = of_iomap(node, 0);
- if (
IS_ERR(data->base)
) {
- err =
PTR_ERR(data->base)
;
+ if (
!data->base
) {
+ err =
-ENODEV
;
goto out_free;
}