projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2f219d5
)
ipv6: fix warning in xfrm6_mode_tunnel_input
author
stephen hemminger
<
[email protected]
>
Sat, 16 Feb 2013 07:38:15 +0000
(07:38 +0000)
committer
David S. Miller
<
[email protected]
>
Mon, 18 Feb 2013 17:42:47 +0000
(12:42 -0500)
Should not use assignment in conditional:
warning: suggest parentheses around assignment used as truth value [-Wparentheses]
Problem introduced by:
commit
14bbd6a565e1bcdc240d44687edb93f721cfdf99
Author: Pravin B Shelar <
[email protected]
>
Date: Thu Feb 14 09:44:49 2013 +0000
net: Add skb_unclone() helper function.
Signed-off-by: Stephen Hemminger <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
net/ipv6/xfrm6_mode_tunnel.c
patch
|
blob
|
history
diff --git
a/net/ipv6/xfrm6_mode_tunnel.c
b/net/ipv6/xfrm6_mode_tunnel.c
index 93c41a81c4c32632338a87c43e0adf368ca2c7da..9bf6a74a71d261061201e3863fd32713c91720d7 100644
(file)
--- a/
net/ipv6/xfrm6_mode_tunnel.c
+++ b/
net/ipv6/xfrm6_mode_tunnel.c
@@
-69,7
+69,8
@@
static int xfrm6_mode_tunnel_input(struct xfrm_state *x, struct sk_buff *skb)
if (!pskb_may_pull(skb, sizeof(struct ipv6hdr)))
goto out;
- if (err = skb_unclone(skb, GFP_ATOMIC))
+ err = skb_unclone(skb, GFP_ATOMIC);
+ if (err)
goto out;
if (x->props.flags & XFRM_STATE_DECAP_DSCP)