projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3a336cb
)
cxgb4: Delete an unnecessary check before the function call "release_firmware"
author
Markus Elfring
<
[email protected]
>
Wed, 4 Feb 2015 10:28:43 +0000
(11:28 +0100)
committer
David S. Miller
<
[email protected]
>
Thu, 5 Feb 2015 08:06:47 +0000
(
00:06
-0800)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 041742b5e0e8f10078e641a0f26bbecadd8af044..5db5b4f7b94d7ff29f86ba478cbdc7f75bf2e0e5 100644
(file)
--- a/
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@
-5142,8
+5142,7
@@
static int adap_init0(struct adapter *adap)
state, &reset);
/* Cleaning up */
- if (fw != NULL)
- release_firmware(fw);
+ release_firmware(fw);
t4_free_mem(card_fw);
if (ret < 0)