projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7c287f1
)
[media] xc5000: properly report i2c write failures
author
Devin Heitmueller
<
[email protected]
>
Tue, 7 Aug 2012 01:46:57 +0000
(22:46 -0300)
committer
Mauro Carvalho Chehab
<
[email protected]
>
Thu, 9 Aug 2012 23:33:13 +0000
(20:33 -0300)
The logic as written would *never* actually return an error condition,
since the loop would run until the counter hit zero but the check was
for a value less than zero.
Signed-off-by: Devin Heitmueller <
[email protected]
>
Signed-off-by: Mauro Carvalho Chehab <
[email protected]
>
drivers/media/common/tuners/xc5000.c
patch
|
blob
|
history
diff --git
a/drivers/media/common/tuners/xc5000.c
b/drivers/media/common/tuners/xc5000.c
index a3f775a2ccd7c37220f4025cca956676ab7e652f..7189e06fb35f0d4c263fa601079a2d14d65c29bd 100644
(file)
--- a/
drivers/media/common/tuners/xc5000.c
+++ b/
drivers/media/common/tuners/xc5000.c
@@
-343,7
+343,7
@@
static int xc_write_reg(struct xc5000_priv *priv, u16 regAddr, u16 i2cData)
}
}
}
- if (WatchDogTimer < 0)
+ if (WatchDogTimer <
=
0)
result = XC_RESULT_I2C_WRITE_FAILURE;
return result;