usb: dwc3: fix wrong bit mask in dwc3_event_devt
authorHuang Rui <[email protected]>
Tue, 7 Jan 2014 09:45:50 +0000 (17:45 +0800)
committerFelipe Balbi <[email protected]>
Thu, 20 Feb 2014 15:16:41 +0000 (09:16 -0600)
Around DWC USB3 2.30a release another bit has been added to the
Device-Specific Event (DEVT) Event Information (EvtInfo) bitfield.

Because of that, what used to be 8 bits long, has become 9 bits long.

Per dwc3 2.30a+ spec in the Device-Specific Event (DEVT), the field of
Event Information Bits(EvtInfo) uses [24:16] bits, and it has 9 bits
not 8 bits. And the following reserved field uses [31:25] bits not
[31:24] bits, and it has 7 bits.

So in dwc3_event_devt, the bit mask should be:
event_info [24:16] 9 bits
reserved31_25 [31:25] 7 bits

This patch makes sure that newer core releases will work fine with
Linux and that we will decode the event information properly on new
core releases.

[email protected] : improve commit log a bit ]

Cc: <[email protected]>
Signed-off-by: Huang Rui <[email protected]>
Signed-off-by: Felipe Balbi <[email protected]>
drivers/usb/dwc3/core.h

index f8af8d44af850075b60a64e1eac29e54bef7fc5a..69c4583933d1eb512d9207e7bd88e1d4fd7f70b7 100644 (file)
@@ -815,15 +815,15 @@ struct dwc3_event_depevt {
  *     12      - VndrDevTstRcved
  * @reserved15_12: Reserved, not used
  * @event_info: Information about this event
- * @reserved31_24: Reserved, not used
+ * @reserved31_25: Reserved, not used
  */
 struct dwc3_event_devt {
        u32     one_bit:1;
        u32     device_event:7;
        u32     type:4;
        u32     reserved15_12:4;
-       u32     event_info:8;
-       u32     reserved31_24:8;
+       u32     event_info:9;
+       u32     reserved31_25:7;
 } __packed;
 
 /**