tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()
authorOleg Nesterov <[email protected]>
Fri, 27 Jun 2014 17:01:43 +0000 (19:01 +0200)
committerSteven Rostedt <[email protected]>
Mon, 30 Jun 2014 17:22:23 +0000 (13:22 -0400)
commitf786106e8081bbec57053fec7fcf25dc25d02144
treefc2172ed8bc049c35548052b717e1a1ffa7c7a9f
parent06d0713904e508f765e0d7146c14b67bbd248fe7
tracing/uprobes: Kill the bogus UPROBE_HANDLER_REMOVE code in uprobe_dispatcher()

I do not know why dd9fa555d7bb "tracing/uprobes: Move argument fetching
to uprobe_dispatcher()" added the UPROBE_HANDLER_REMOVE, but it looks
wrong.

OK, perhaps it makes sense to avoid store_trace_args() if the tracee is
nacked by uprobe_perf_filter(). But then we should kill the same code
in uprobe_perf_func() and unify the TRACE/PROFILE filtering (we need to
do this anyway to mix perf/ftrace). Until then this code actually adds
the pessimization because uprobe_perf_filter() will be called twice and
return T in likely case.

Link: http://lkml.kernel.org/p/[email protected]
Acked-by: Namhyung Kim <[email protected]>
Acked-by: Srikar Dronamraju <[email protected]>
Signed-off-by: Oleg Nesterov <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
kernel/trace/trace_uprobe.c