kernel/params.c: downgrade warning for unsafe parameters
authorChris Wilson <[email protected]>
Tue, 10 Apr 2018 23:35:18 +0000 (16:35 -0700)
committerLinus Torvalds <[email protected]>
Wed, 11 Apr 2018 17:28:37 +0000 (10:28 -0700)
commitedc41b3c5489996e4c1ec820bf102660bf745c45
tree392b1556e06506bfb80de5b41e19720b2527c693
parent2d87b309a5d66c3ec0b4d985fe29b547282e7427
kernel/params.c: downgrade warning for unsafe parameters

As using an unsafe module parameter is, by its very definition, an
expected user action, emitting a warning is overkill.  Nothing has yet
gone wrong, and we add a taint flag for any future oops should something
actually go wrong.  So instead of having a user controllable pr_warn,
downgrade it to a pr_notice for "a normal, but significant condition".

We make use of unsafe kernel parameters in igt
(https://cgit.freedesktop.org/drm/igt-gpu-tools/) (we have not yet
succeeded in removing all such debugging options), which generates a
warning and taints the kernel.  The warning is unhelpful as we then need
to filter it out again as we check that every test themselves do not
provoke any kernel warnings.

Link: http://lkml.kernel.org/r/[email protected]
Fixes: 91f9d330cc14 ("module: make it possible to have unsafe, tainting module params")
Signed-off-by: Chris Wilson <[email protected]>
Acked-by: Jani Nikula <[email protected]>
Reviewed-by: Andrew Morton <[email protected]>
Cc: Rusty Russell <[email protected]>
Cc: Jean Delvare <[email protected]>
Cc: Li Zhong <[email protected]>
Cc: Petri Latvala <[email protected]>
Cc: Daniel Vetter <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
kernel/params.c