md: don't call ->add_disk unless there is good reason.
authorNeilBrown <[email protected]>
Tue, 24 Apr 2012 00:23:14 +0000 (10:23 +1000)
committerNeilBrown <[email protected]>
Tue, 24 Apr 2012 00:23:14 +0000 (10:23 +1000)
commited209584c38fb74b7eecc03e5b1bfe674e591bd8
treea232bb4fbf3a2e143ad57dfa3acad92418c5b12c
parenta9ad8526bb1af0741a5c0e01155dac08e7bdde60
md: don't call ->add_disk unless there is good reason.

Commit 7bfec5f35c68121e7b18

   md/raid5: If there is a spare and a want_replacement device, start replacement.

cause md_check_recovery to call ->add_disk much more often.
Instead of only when the array is degraded, it is now called whenever
md_check_recovery finds anything useful to do, which includes
updating the metadata for clean<->dirty transition.
This causes unnecessary work, and causes info messages from ->add_disk
to be reported much too often.

So refine md_check_recovery to only do any actual recovery checking
(including ->add_disk) if MD_RECOVERY_NEEDED is set.

This fix is suitable for 3.3.y:

Cc: [email protected]
Reported-by: Jan Ceuleers <[email protected]>
Signed-off-by: NeilBrown <[email protected]>
drivers/md/md.c