batman-adv: Fix parameter order of hlist_add_behind
authorSven Eckelmann <[email protected]>
Fri, 15 Aug 2014 08:19:39 +0000 (10:19 +0200)
committerDavid S. Miller <[email protected]>
Sun, 17 Aug 2014 02:19:08 +0000 (19:19 -0700)
commite050dbeb0d1e19072d0d656b51f06af1af860f19
treeca105c43b61e75c6838003abbbdd822e037b19c7
parented607b82cad5bc72957b4c8c4b35670950c3b0de
batman-adv: Fix parameter order of hlist_add_behind

1d023284c31a4e40a94d5bbcb7dbb7a35ee0bcbc ("list: fix order of arguments for
hlist_add_after(_rcu)") was incorrectly rebased on top of
d9124268d84a836f14a6ead54ff9d8eee4c43be5 ("batman-adv: Fix out-of-order
fragmentation support"). The parameter order change of the rebased patch was
not re-applied as expected. This causes a memory leak and can cause crashes
when out-of-order packets are received. hlist_add_behind will try to access the
uninitalized list pointers of frag_entry_new to find the previous/next entry
and may modify/read random memory locations.

Signed-off-by: Sven Eckelmann <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/batman-adv/fragmentation.c