net: fix circular dependency in of_mdio code
authorDaniel Mack <[email protected]>
Fri, 27 Jun 2014 23:23:35 +0000 (01:23 +0200)
committerDavid S. Miller <[email protected]>
Wed, 2 Jul 2014 07:24:14 +0000 (00:24 -0700)
commitd9daa24720891a88bedb93928f57767da96e5c80
treef661313d5ecf270e5fbbe43847b3e0a6411d18e0
parenteb608d2b99d993a4b4ee9cb70e6cf66f96bb1168
net: fix circular dependency in of_mdio code

Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev()) introduced a
circular dependency between libphy and of_mdio.

depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
dependency cycle!
depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!

The problem is that of_mdio.c references &mdio_bus_type and libphy now
references of_mdiobus_link_phydev.

Fix this by not exporting of_mdiobus_link_phydev() from of_mdio.ko.
Make it a static function in mdio_bus.c instead.

Signed-off-by: Daniel Mack <[email protected]>
Reported-by: Jeff Mahoney <[email protected]>
Fixes: 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
Reviewed-by: Florian Fainelli <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/net/phy/mdio_bus.c
drivers/of/of_mdio.c
include/linux/of_mdio.h