mm: drop migrate type checks from has_unmovable_pages
authorMichal Hocko <[email protected]>
Thu, 16 Nov 2017 01:33:22 +0000 (17:33 -0800)
committerLinus Torvalds <[email protected]>
Thu, 16 Nov 2017 02:21:02 +0000 (18:21 -0800)
commitd7b236e10cedd95373a79fd53b7e9c105bea4f08
tree8deeb1385ace737b7c56591fc0e357e661302908
parent4c578dce58038a5b3cb7ffc77a5f62ef2c5d0856
mm: drop migrate type checks from has_unmovable_pages

Michael has noticed that the memory offline tries to migrate kernel code
pages when doing

 echo 0 > /sys/devices/system/memory/memory0/online

The current implementation will fail the operation after several failed
page migration attempts but we shouldn't even attempt to migrate that
memory and fail right away because this memory is clearly not
migrateable.  This will become a real problem when we drop the retry
loop counter resp.  timeout.

The real problem is in has_unmovable_pages in fact.  We should fail if
there are any non migrateable pages in the area.  In orther to guarantee
that remove the migrate type checks because MIGRATE_MOVABLE is not
guaranteed to contain only migrateable pages.  It is merely a heuristic.
Similarly MIGRATE_CMA does guarantee that the page allocator doesn't
allocate any non-migrateable pages from the block but CMA allocations
themselves are unlikely to migrateable.  Therefore remove both checks.

[[email protected]: remove unused local `mt']
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Michal Hocko <[email protected]>
Reported-by: Michael Ellerman <[email protected]>
Tested-by: Michael Ellerman <[email protected]>
Acked-by: Vlastimil Babka <[email protected]>
Tested-by: Tony Lindgren <[email protected]>
Tested-by: Ran Wang <[email protected]>
Cc: Igor Mammedov <[email protected]>
Cc: KAMEZAWA Hiroyuki <[email protected]>
Cc: Reza Arbab <[email protected]>
Cc: Vitaly Kuznetsov <[email protected]>
Cc: Xishi Qiu <[email protected]>
Cc: Yasuaki Ishimatsu <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/page_alloc.c