mm/page-writeback: fix dirty_ratelimit calculation
authorAndrey Ryabinin <[email protected]>
Tue, 15 Mar 2016 21:55:27 +0000 (14:55 -0700)
committerLinus Torvalds <[email protected]>
Tue, 15 Mar 2016 23:55:16 +0000 (16:55 -0700)
commitd59b1087a98e402ed9a7cc577f4da435f9a555f5
treec0d59e0a254d7c4b9f31ee3a4873423cc200ee35
parentb72d0ffb5dbc4070089b36230b98687ca4577cbc
mm/page-writeback: fix dirty_ratelimit calculation

Calculation of dirty_ratelimit sometimes is not correct.  E.g.  initial
values of dirty_ratelimit == INIT_BW and step == 0, lead to the
following result:

   UBSAN: Undefined behaviour in ../mm/page-writeback.c:1286:7
   shift exponent 25600 is too large for 64-bit type 'long unsigned int'

The fix is straightforward - make step 0 if the shift exponent is too
big.

Signed-off-by: Andrey Ryabinin <[email protected]>
Cc: Wu Fengguang <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/page-writeback.c