lib/bitmap.c: fix remaining space computation in bitmap_print_to_pagebuf
authorRasmus Villemoes <[email protected]>
Tue, 30 Oct 2018 22:05:14 +0000 (15:05 -0700)
committerLinus Torvalds <[email protected]>
Wed, 31 Oct 2018 15:54:12 +0000 (08:54 -0700)
commitce1091d471107dbf6f91db66a480a25950c9b9ff
tree7a38d2419b4a97761bad138cac431a48fa0c7d33
parent41e7b1661ffbf562d3aa2b7ce4ad283db50b711a
lib/bitmap.c: fix remaining space computation in bitmap_print_to_pagebuf

For various alignments of buf, the current expression computes

4096 ok
4095 ok
8190
8189
...
4097

i.e., if the caller has already written two bytes into the page buffer,
len is 8190 rather than 4094, because PTR_ALIGN aligns up to the next
boundary.  So if the printed version of the bitmap is huge, scnprintf()
ends up writing beyond the page boundary.

I don't think any current callers actually write anything before
bitmap_print_to_pagebuf, but the API seems to be designed to allow it.

[[email protected]: use offset_in_page(), per Andy]
[[email protected]: include mm.h for offset_in_page()]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Rasmus Villemoes <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Cc: Yury Norov <[email protected]>
Cc: Rasmus Villemoes <[email protected]>
Cc: Sudeep Holla <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
lib/bitmap.c