mm/vmalloc: fix show vmap_area information race with vmap_area tear down
authorWanpeng Li <[email protected]>
Tue, 12 Nov 2013 23:07:31 +0000 (15:07 -0800)
committerLinus Torvalds <[email protected]>
Wed, 13 Nov 2013 03:09:05 +0000 (12:09 +0900)
commitc2ce8c142c43c360047e173d2018d94a4d0f7a59
tree089e2f2e337d599380ca48fe5dbc625699ea91ce
parent3722e13cff361035583f6ecfa784437b824fe659
mm/vmalloc: fix show vmap_area information race with vmap_area tear down

There is a race window between vmap_area tear down and show vmap_area
information.

A                                                B

remove_vm_area
spin_lock(&vmap_area_lock);
va->vm = NULL;
va->flags &= ~VM_VM_AREA;
spin_unlock(&vmap_area_lock);
spin_lock(&vmap_area_lock);
if (va->flags & (VM_LAZY_FREE | VM_LAZY_FREEZING))
return 0;
if (!(va->flags & VM_VM_AREA)) {
seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n",
(void *)va->va_start, (void *)va->va_end,
va->va_end - va->va_start);
return 0;
}
free_unmap_vmap_area(va);
flush_cache_vunmap
free_unmap_vmap_area_noflush
unmap_vmap_area
free_vmap_area_noflush
va->flags |= VM_LAZY_FREE

The assumption !VM_VM_AREA represents vm_map_ram allocation is
introduced by d4033afdf828 ("mm, vmalloc: iterate vmap_area_list,
instead of vmlist, in vmallocinfo()").

However, !VM_VM_AREA also represents vmap_area is being tear down in
race window mentioned above.  This patch fix it by don't dump any
information for !VM_VM_AREA case and also remove (VM_LAZY_FREE |
VM_LAZY_FREEING) check since they are not possible for !VM_VM_AREA case.

Suggested-by: Joonsoo Kim <[email protected]>
Acked-by: KOSAKI Motohiro <[email protected]>
Signed-off-by: Wanpeng Li <[email protected]>
Cc: Mitsuo Hayasaka <[email protected]>
Cc: Zhang Yanfei <[email protected]>
Cc: David Rientjes <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/vmalloc.c