x86/boot: Fix kexec booting failure in the SEV bit detection code
authorKairui Song <[email protected]>
Thu, 27 Sep 2018 12:38:45 +0000 (20:38 +0800)
committerBorislav Petkov <[email protected]>
Thu, 27 Sep 2018 17:35:03 +0000 (19:35 +0200)
commitbdec8d7fa55e6f5314ed72e5a0b435d90ff90548
treeaaafb2bba10a7d633623bc6304084c16e5d628ce
parent05ab1d8a4b36ee912b7087c6da127439ed0a903e
x86/boot: Fix kexec booting failure in the SEV bit detection code

Commit

  1958b5fc4010 ("x86/boot: Add early boot support when running with SEV active")

can occasionally cause system resets when kexec-ing a second kernel even
if SEV is not active.

That's because get_sev_encryption_bit() uses 32-bit rIP-relative
addressing to read the value of enc_bit - a variable which caches a
previously detected encryption bit position - but kexec may allocate
the early boot code to a higher location, beyond the 32-bit addressing
limit.

In this case, garbage will be read and get_sev_encryption_bit() will
return the wrong value, leading to accessing memory with the wrong
encryption setting.

Therefore, remove enc_bit, and thus get rid of the need to do 32-bit
rIP-relative addressing in the first place.

 [ bp: massage commit message heavily. ]

Fixes: 1958b5fc4010 ("x86/boot: Add early boot support when running with SEV active")
Suggested-by: Borislav Petkov <[email protected]>
Signed-off-by: Kairui Song <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Reviewed-by: Tom Lendacky <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Link: https://lkml.kernel.org/r/[email protected]
arch/x86/boot/compressed/mem_encrypt.S