bridge: fix hello and hold timers starting/stopping
authorIvan Vecera <[email protected]>
Fri, 19 May 2017 17:30:43 +0000 (19:30 +0200)
committerDavid S. Miller <[email protected]>
Mon, 22 May 2017 18:40:22 +0000 (14:40 -0400)
commitbd080488a6cfd37135becedfdc87643b139c2345
treeb3ec5d73cf9895423e5e75cd7985821d0c0a65be
parent85deed56032b6c98b541895bfda9bdd74f6ed987
bridge: fix hello and hold timers starting/stopping

Current bridge code incorrectly handles starting/stopping of hello and
hold timers during STP enable/disable.

1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
   transition. The timers are already stopped in NO_STP state so
   this is confusing no-op.

2. During USER_STP->NO_STP transition the timers are started. This
   does not make sense and is confusion because the timer should not be
   active in NO_STP state.

Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Ivan Vecera <[email protected]>
Reviewed-by: Xin Long <[email protected]>
Acked-by: Nikolay Aleksandrov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/bridge/br_stp_if.c