oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()
authorOleg Nesterov <[email protected]>
Tue, 21 Jan 2014 23:50:00 +0000 (15:50 -0800)
committerLinus Torvalds <[email protected]>
Wed, 22 Jan 2014 00:19:46 +0000 (16:19 -0800)
commitad96244179fbd55b40c00f10f399bc04739b8e1f
tree8bb173d243351b07f38cce9e6bb1b67db628222f
parent1da4db0cd5c8a31d4468ec906b413e75e604b465
oom_kill: has_intersects_mems_allowed() needs rcu_read_lock()

At least out_of_memory() calls has_intersects_mems_allowed() without
even rcu_read_lock(), this is obviously buggy.

Add the necessary rcu_read_lock().  This means that we can not simply
return from the loop, we need "bool ret" and "break".

While at it, swap the names of task_struct's (the argument and the
local).  This cleans up the code a little bit and avoids the unnecessary
initialization.

Signed-off-by: Oleg Nesterov <[email protected]>
Reviewed-by: Sergey Dyasly <[email protected]>
Tested-by: Sergey Dyasly <[email protected]>
Reviewed-by: Sameer Nanda <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Mandeep Singh Baines <[email protected]>
Cc: "Ma, Xindong" <[email protected]>
Reviewed-by: Michal Hocko <[email protected]>
Cc: "Tu, Xiaobing" <[email protected]>
Acked-by: David Rientjes <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/oom_kill.c