ipv6: fix rtnl locking in setsockopt for anycast and multicast
authorSabrina Dubroca <[email protected]>
Tue, 2 Sep 2014 08:29:29 +0000 (10:29 +0200)
committerDavid S. Miller <[email protected]>
Fri, 5 Sep 2014 18:52:28 +0000 (11:52 -0700)
commita9ed4a2986e13011fcf4ed2d1a1647c53112f55b
tree508293e1b03b96cfdfd05e57ddd8dc60c0157b1d
parent4ad9a64f53c619969dede1143d56ccda1a453c39
ipv6: fix rtnl locking in setsockopt for anycast and multicast

Calling setsockopt with IPV6_JOIN_ANYCAST or IPV6_LEAVE_ANYCAST
triggers the assertion in addrconf_join_solict()/addrconf_leave_solict()

ipv6_sock_ac_join(), ipv6_sock_ac_drop(), ipv6_sock_ac_close() need to
take RTNL before calling ipv6_dev_ac_inc/dec. Same thing with
ipv6_sock_mc_join(), ipv6_sock_mc_drop(), ipv6_sock_mc_close() before
calling ipv6_dev_mc_inc/dec.

This patch moves ASSERT_RTNL() up a level in the call stack.

Signed-off-by: Cong Wang <[email protected]>
Signed-off-by: Sabrina Dubroca <[email protected]>
Reported-by: Tommi Rantala <[email protected]>
Acked-by: Hannes Frederic Sowa <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/ipv6/addrconf.c
net/ipv6/anycast.c
net/ipv6/mcast.c