slub: Fix double bit unlock in debug mode
authorChristoph Lameter <[email protected]>
Wed, 25 May 2011 14:47:43 +0000 (09:47 -0500)
committerLinus Torvalds <[email protected]>
Wed, 25 May 2011 15:38:24 +0000 (08:38 -0700)
commita71ae47a2cbfa542c69f695809124da4e4dd9e8f
treea6b563bbab796f404fc68fdeebdf9a1c1e2fc27b
parent4a7df24ddc7097cd789a7527187826552ea0765e
slub: Fix double bit unlock in debug mode

Commit 442b06bcea23 ("slub: Remove node check in slab_free") added a
call to deactivate_slab() in the debug case in __slab_alloc(), which
unlocks the current slab used for allocation.  Going to the label
'unlock_out' then does it again.

Also, in the debug case we do not need all the other processing that the
'unlock_out' path does.  We always fall back to the slow path in the
debug case.  So the tid update is useless.

Similarly, ALLOC_SLOWPATH would just be incremented for all allocations.
Also a pretty useless thing.

So simply restore irq flags and return the object.

Signed-off-by: Christoph Lameter <[email protected]>
Reported-and-bisected-by: James Morris <[email protected]>
Reported-by: Ingo Molnar <[email protected]>
Reported-by: Jens Axboe <[email protected]>
Cc: Pekka Enberg <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
mm/slub.c