perf: Fix perf bug in fork()
authorPeter Zijlstra <[email protected]>
Mon, 29 Sep 2014 10:12:01 +0000 (12:12 +0200)
committerIngo Molnar <[email protected]>
Fri, 3 Oct 2014 03:41:08 +0000 (05:41 +0200)
commit9c2b9d30e28559a78c9e431cdd7f2c6bf5a9ee67
tree63e8e2f6c3a9fb68ed907b69e85cbce333d7ff2b
parent211de6eba8960521e2be450a7d07db85fba4604c
perf: Fix perf bug in fork()

Oleg noticed that a cleanup by Sylvain actually uncovered a bug; by
calling perf_event_free_task() when failing sched_fork() we will not yet
have done the memset() on ->perf_event_ctxp[] and will therefore try and
'free' the inherited contexts, which are still in use by the parent
process.

This is bad and might explain some outstanding fuzzer failures ...

Suggested-by: Oleg Nesterov <[email protected]>
Reported-by: Oleg Nesterov <[email protected]>
Reported-by: Sylvain 'ythier' Hitier <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Aaron Tomlin <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Daeseok Youn <[email protected]>
Cc: David Rientjes <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Rik van Riel <[email protected]>
Cc: Vladimir Davydov <[email protected]>
Cc: <[email protected]>
Link: http://lkml.kernel.org/r/20140929101201.GE5430@worktop
Signed-off-by: Ingo Molnar <[email protected]>
kernel/events/core.c
kernel/fork.c