net: fix socket refcounting in skb_complete_tx_timestamp()
authorEric Dumazet <[email protected]>
Sat, 4 Mar 2017 05:01:03 +0000 (21:01 -0800)
committerDavid S. Miller <[email protected]>
Tue, 7 Mar 2017 22:06:15 +0000 (14:06 -0800)
commit9ac25fc063751379cb77434fef9f3b088cd3e2f7
tree411965f359568a7dfd8c23d68fbb0d68e43c356e
parentdd4f10722aeb10f4f582948839f066bebe44e5fb
net: fix socket refcounting in skb_complete_tx_timestamp()

TX skbs do not necessarily hold a reference on skb->sk->sk_refcnt
By the time TX completion happens, sk_refcnt might be already 0.

sock_hold()/sock_put() would then corrupt critical state, like
sk_wmem_alloc and lead to leaks or use after free.

Fixes: 62bccb8cdb69 ("net-timestamp: Make the clone operation stand-alone from phy timestamping")
Signed-off-by: Eric Dumazet <[email protected]>
Cc: Alexander Duyck <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Soheil Hassas Yeganeh <[email protected]>
Cc: Willem de Bruijn <[email protected]>
Acked-by: Soheil Hassas Yeganeh <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/core/skbuff.c