platform/x86: wmi: Call acpi_wmi_init() later
authorRafael J. Wysocki <[email protected]>
Wed, 3 Jan 2018 11:49:29 +0000 (12:49 +0100)
committerDarren Hart (VMware) <[email protected]>
Sat, 6 Jan 2018 01:35:27 +0000 (17:35 -0800)
commit9a1a6259184794773019aa2d242e15d81168fc18
treeafd64cb22dfe5f10cc18b39d475ecb846ec7ae3d
parenta346aa204020f30c7b9152da675f431246c70160
platform/x86: wmi: Call acpi_wmi_init() later

Calling acpi_wmi_init() at the subsys_initcall() level causes ordering
issues to appear on some systems and they are difficult to reproduce,
because there is no guaranteed ordering between subsys_initcall()
calls, so they may occur in different orders on different systems.

In particular, commit 86d9f48534e8 (mm/slab: fix kmemcg cache
creation delayed issue) exposed one of these issues where genl_init()
and acpi_wmi_init() are both called at the same initcall level, but
the former must run before the latter so as to avoid a NULL pointer
dereference.

For this reason, move the acpi_wmi_init() invocation to the
initcall_sync level which should still be early enough for things
to work correctly in the WMI land.

Link: https://marc.info/?t=151274596700002&r=1&w=2
Reported-by: Jonathan McDowell <[email protected]>
Reported-by: Joonsoo Kim <[email protected]>
Tested-by: Jonathan McDowell <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
Signed-off-by: Darren Hart (VMware) <[email protected]>
drivers/platform/x86/wmi.c