udp: optimize bind(0) if many ports are in use
authorEric Dumazet <[email protected]>
Tue, 27 Jan 2009 05:35:35 +0000 (21:35 -0800)
committerDavid S. Miller <[email protected]>
Tue, 27 Jan 2009 05:35:35 +0000 (21:35 -0800)
commit98322f22eca889478045cf896b572250d03dc45f
tree22a06e97ece02db900f7d4f496639582b828a4ee
parent8527bec548e01a29c6d1928d20d6d3be71861482
udp: optimize bind(0) if many ports are in use

commit 9088c5609584684149f3fb5b065aa7f18dcb03ff
(udp: Improve port randomization) introduced a regression for UDP bind() syscall
to null port (getting a random port) in case lot of ports are already in use.

This is because we do about 28000 scans of very long chains (220 sockets per chain),
with many spin_lock_bh()/spin_unlock_bh() calls.

Fix this using a bitmap (64 bytes for current value of UDP_HTABLE_SIZE)
so that we scan chains at most once.

Instead of 250 ms per bind() call, we get after patch a time of 2.9 ms

Based on a report from Vitaly Mayatskikh

Reported-by: Vitaly Mayatskikh <[email protected]>
Signed-off-by: Eric Dumazet <[email protected]>
Tested-by: Vitaly Mayatskikh <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
net/ipv4/udp.c