prctl: avoid using mmap_sem for exe_file serialization
authorDavidlohr Bueso <[email protected]>
Thu, 16 Apr 2015 19:47:59 +0000 (12:47 -0700)
committerLinus Torvalds <[email protected]>
Fri, 17 Apr 2015 13:04:07 +0000 (09:04 -0400)
commit6e399cd144d8500ffb5d40fa6848890e2580a80a
tree930e8ec3664bc6b14c562f38acdc511ea7e938b8
parent90f31d0ea88880f780574f3d0bb1a227c4c66ca3
prctl: avoid using mmap_sem for exe_file serialization

Oleg cleverly suggested using xchg() to set the new mm->exe_file instead
of calling set_mm_exe_file() which requires some form of serialization --
mmap_sem in this case.  For archs that do not have atomic rmw instructions
we still fallback to a spinlock alternative, so this should always be
safe.  As such, we only need the mmap_sem for looking up the backing
vm_file, which can be done sharing the lock.  Naturally, this means we
need to manually deal with both the new and old file reference counting,
and we need not worry about the MMF_EXE_FILE_CHANGED bits, which can
probably be deleted in the future anyway.

Signed-off-by: Davidlohr Bueso <[email protected]>
Suggested-by: Oleg Nesterov <[email protected]>
Acked-by: Oleg Nesterov <[email protected]>
Reviewed-by: Konstantin Khlebnikov <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
fs/exec.c
kernel/fork.c
kernel/sys.c