ptrace: ptrace_detach() can no longer race with SIGKILL
authorOleg Nesterov <[email protected]>
Thu, 16 Apr 2015 19:47:32 +0000 (12:47 -0700)
committerLinus Torvalds <[email protected]>
Fri, 17 Apr 2015 13:04:06 +0000 (09:04 -0400)
commit64a4096c5cdab377b6e1f44008ee8b2636db579d
tree5cb701ad9bd68e19f6da29b29c086215b0292b67
parentb72c186999e689cb0b055ab1c7b3cd8fffbeb5ed
ptrace: ptrace_detach() can no longer race with SIGKILL

ptrace_detach() re-checks ->ptrace under tasklist lock and calls
release_task() if __ptrace_detach() returns true.  This was needed because
the __TASK_TRACED tracee could be killed/untraced, and it could even pass
exit_notify() before we take tasklist_lock.

But this is no longer possible after 9899d11f6544 "ptrace: ensure
arch_ptrace/ptrace_request can never race with SIGKILL".  We can turn
these checks into WARN_ON() and remove release_task().

While at it, document the setting of child->exit_code.

Signed-off-by: Oleg Nesterov <[email protected]>
Cc: Pavel Labath <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
kernel/ptrace.c