rtc: rtc-at91rm9200: fix infinite wait for ACKUPD irq
authorBoris BREZILLON <[email protected]>
Fri, 6 Jun 2014 21:36:09 +0000 (14:36 -0700)
committerLinus Torvalds <[email protected]>
Fri, 6 Jun 2014 23:08:08 +0000 (16:08 -0700)
commit2fe121e1f5aa3bf31b418a9790db6c400e922291
tree0a0e52c511dbeb8d45b0e26a2399f5bcc7ed6737
parent68164a73b1055191975419f5da7180294902f461
rtc: rtc-at91rm9200: fix infinite wait for ACKUPD irq

The rtc user must wait at least 1 sec between each time/calandar update
(see atmel's datasheet chapter "Updating Time/Calendar").

Use the 1Hz interrupt to update the at91_rtc_upd_rdy flag and wait for
the at91_rtc_wait_upd_rdy event if the rtc is not ready.

This patch fixes a deadlock in an uninterruptible wait when the RTC is
updated more than once every second.  AFAICT the bug is here from the
beginning, but I think we should at least backport this fix to 3.10 and
the following longterm and stable releases.

Signed-off-by: Boris BREZILLON <[email protected]>
Reported-by: Bryan Evenson <[email protected]>
Tested-by: Bryan Evenson <[email protected]>
Cc: Andrew Victor <[email protected]>
Cc: Nicolas Ferre <[email protected]>
Cc: Jean-Christophe Plagniol-Villard <[email protected]>
Cc: Alessandro Zummo <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
drivers/rtc/rtc-at91rm9200.c