drm/i915/fbdev: Enable late fbdev initial configuration
authorJosé Roberto de Souza <[email protected]>
Wed, 18 Apr 2018 23:41:58 +0000 (16:41 -0700)
committerJoonas Lahtinen <[email protected]>
Wed, 25 Apr 2018 06:50:35 +0000 (09:50 +0300)
commit0b551f1e0fc50ee4e3cde2dd639cb010dae5b997
tree461aac29e5854a54ed8432ef8661cfe8093484c7
parent6de3b1f26d1e8adb53d97835400c541ce50155e5
drm/i915/fbdev: Enable late fbdev initial configuration

If the initial fbdev configuration (intel_fbdev_initial_config()) runs
and there still no sink connected it will cause
drm_fb_helper_initial_config() to return 0 as no error happened (but
internally the return is -EAGAIN).  Because no framebuffer was
allocated, when a sink is connected intel_fbdev_output_poll_changed()
will not execute drm_fb_helper_hotplug_event() that would trigger
another try to do the initial fbdev configuration.

So here allowing drm_fb_helper_hotplug_event() to be executed when there
is no framebuffer allocated and fbdev was not set up yet.

This issue also happens when a MST DP sink is connected since boot, as
the MST topology is discovered in parallel if
intel_fbdev_initial_config() is executed before the first sink MST is
discovered it will cause this same issue.

This is a follow-up patch of
https://patchwork.freedesktop.org/patch/196089/

Changes from v1:
- not creating a dump framebuffer anymore, instead just allowing
  drm_fb_helper_hotplug_event() to execute when fbdev is not setup yet.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104158
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104425
Cc: Rodrigo Vivi <[email protected]>
Cc: [email protected] # v4.15+
Signed-off-by: Chris Wilson <[email protected]>
Signed-off-by: José Roberto de Souza <[email protected]>
Tested-by: Paul Menzel <[email protected]>
Tested-by: frederik <[email protected]> # 4.15.17
Tested-by: Ian Pilcher <[email protected]>
Acked-by: Chris Wilson <[email protected]>
Signed-off-by: Jani Nikula <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
(cherry picked from commit df9e6521749ab33cde306e8a4350b0ac7889220a)
Signed-off-by: Joonas Lahtinen <[email protected]>
drivers/gpu/drm/i915/intel_fbdev.c