drm/i915: Add helper to get a display power ref if it was already enabled
authorImre Deak <[email protected]>
Wed, 17 Feb 2016 12:17:42 +0000 (14:17 +0200)
committerImre Deak <[email protected]>
Wed, 17 Feb 2016 14:07:17 +0000 (16:07 +0200)
commit09731280028ce03e6a27e1998137f1775a2839f3
tree87e83ae95851ee6c558fb620585b7bceeef7cc46
parent755412e29c7745368316d890dde0398f58c3cf72
drm/i915: Add helper to get a display power ref if it was already enabled

We have many places in the code where we check if a given display power
domain is enabled and if so access registers backed by this power
domain. We assumed that some modeset lock will prevent the power
reference from vanishing in the middle of the HW access, but this
assumption doesn't always hold. In such cases we get either the wakeref
not held, or an unclaimed register access error message. To fix this in
a future-proof way that's independent of other locks wrap any such
access with a get_ref_if_enabled()/put_ref() pair.

Kudos to Ville and Joonas for the ideas of this new interface.

v2:
- init the power_domains ptr when declaring it everywhere (Joonas)
v3:
- don't report the device to be powered if runtime PM is disabled

CC: Mika Kuoppala <[email protected]>
CC: Chris Wilson <[email protected]>
CC: Joonas Lahtinen <[email protected]>
CC: Ville Syrjälä <[email protected]>
Signed-off-by: Imre Deak <[email protected]>
Reviewed-by: Joonas Lahtinen <[email protected]>
Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
drivers/gpu/drm/i915/intel_drv.h
drivers/gpu/drm/i915/intel_runtime_pm.c