MIPS: Fix a preemption issue with thread's FPU defaults
authorMaciej W. Rozycki <[email protected]>
Tue, 12 May 2015 14:20:57 +0000 (15:20 +0100)
committerRalf Baechle <[email protected]>
Tue, 12 May 2015 21:15:49 +0000 (23:15 +0200)
commit03dce595270f22d59a6f37e9170287c1afd94bc2
tree68e8ae5e92d6dda9b32be45d72025b095913671d
parent620b155034570f577470cf5309f741bac6a6e32b
MIPS: Fix a preemption issue with thread's FPU defaults

Fix "BUG: using smp_processor_id() in preemptible" reported in accesses
to thread's FPU defaults: the value to initialise FSCR to at program
startup, the FCSR r/w mask and the contents of FIR in full FPU
emulation, removing a regression introduced with 9b26616c [MIPS: Respect
the ISA level in FCSR handling] and f6843626 [MIPS: math-emu: Set FIR
feature flags for full emulation].

Use `boot_cpu_data' to obtain the data from, following the approach that
`cpu_has_*' macros take and avoiding the call to `smp_processor_id' made
in the reference to `current_cpu_data'.  The contents of FSCR have to be
consistent across processors in an SMP system, the settings there must
not change as a thread is migrated across processors.  And the contents
of FIR are guaranteed to be consistent in FPU emulation, by definition.

Signed-off-by: Maciej W. Rozycki <[email protected]>
Tested-by: Ezequiel Garcia <[email protected]>
Tested-by: Paul Martin <[email protected]>
Cc: Markos Chandras <[email protected]>
Cc: James Hogan <[email protected]>
Cc: [email protected]
Patchwork: https://patchwork.linux-mips.org/patch/10030/
Signed-off-by: Ralf Baechle <[email protected]>
arch/mips/include/asm/elf.h
arch/mips/kernel/ptrace.c
arch/mips/math-emu/cp1emu.c