git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 625fbc16524a45488f6eb8561d98b3328efe79cd Mon Sep 17 00:00:00 2001
   2 From: Chen Ni <nichen@iscas.ac.cn>
   3 Date: Mon, 24 Mar 2025 16:03:03 +0800
   4 Subject: [PATCH] wifi: rtw88: usb: Remove redundant 'flush_workqueue()' calls
   5
   6 'destroy_workqueue()' already drains the queue before destroying it, so
   7 there is no need to flush it explicitly.
   8
   9 Remove the redundant 'flush_workqueue()' calls.
  10
  11 This was generated with coccinelle:
  12
  13 @@
  14 expression E;
  15 @@
  16
  17 - flush_workqueue(E);
  18   destroy_workqueue(E);
  19
  20 Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
  21 Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
  22 Link: https://patch.msgid.link/20250324080303.408084-1-nichen@iscas.ac.cn
  23 ---
  24  drivers/net/wireless/realtek/rtw88/usb.c | 2 --
  25  1 file changed, 2 deletions(-)
  26
  27 --- a/drivers/net/wireless/realtek/rtw88/usb.c
  28 +++ b/drivers/net/wireless/realtek/rtw88/usb.c
  29 @@ -952,7 +952,6 @@ static void rtw_usb_deinit_rx(struct rtw
  30
  31         skb_queue_purge(&rtwusb->rx_queue);
  32
  33 -       flush_workqueue(rtwusb->rxwq);
  34         destroy_workqueue(rtwusb->rxwq);
  35
  36         skb_queue_purge(&rtwusb->rx_free_queue);
  37 @@ -981,7 +980,6 @@ static void rtw_usb_deinit_tx(struct rtw
  38  {
  39         struct rtw_usb *rtwusb = rtw_get_usb_priv(rtwdev);
  40
  41 -       flush_workqueue(rtwusb->txwq);
  42         destroy_workqueue(rtwusb->txwq);
  43         rtw_usb_tx_queue_purge(rtwusb);
  44  }