git.openwrt.org Git - openwrt/staging/xback.git/blob

   1 From 92abfcb4ced482afbe65d18980e6734fe1e62a34 Mon Sep 17 00:00:00 2001
   2 From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
   3 Date: Fri, 8 Nov 2024 16:01:50 +0000
   4 Subject: [PATCH 2/5] net: phylink: move MLO_AN_FIXED resolve handling to if()
   5  statement
   6
   7 The switch() statement doesn't sit very well with the preceeding if()
   8 statements, and results in excessive indentation that spoils code
   9 readability. Begin cleaning this up by converting the MLO_AN_FIXED case
  10 to an if() statement.
  11
  12 Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
  13 Link: https://patch.msgid.link/E1t9RQk-002Fen-1A@rmk-PC.armlinux.org.uk
  14 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  15 ---
  16  drivers/net/phy/phylink.c | 8 +++-----
  17  1 file changed, 3 insertions(+), 5 deletions(-)
  18
  19 --- a/drivers/net/phy/phylink.c
  20 +++ b/drivers/net/phy/phylink.c
  21 @@ -1429,6 +1429,9 @@ static void phylink_resolve(struct work_
  22         } else if (pl->mac_link_dropped) {
  23                 link_state.link = false;
  24                 retrigger = true;
  25 +       } else if (pl->cur_link_an_mode == MLO_AN_FIXED) {
  26 +               phylink_get_fixed_state(pl, &link_state);
  27 +               mac_config = link_state.link;
  28         } else {
  29                 switch (pl->cur_link_an_mode) {
  30                 case MLO_AN_PHY:
  31 @@ -1436,11 +1439,6 @@ static void phylink_resolve(struct work_
  32                         mac_config = link_state.link;
  33                         break;
  34
  35 -               case MLO_AN_FIXED:
  36 -                       phylink_get_fixed_state(pl, &link_state);
  37 -                       mac_config = link_state.link;
  38 -                       break;
  39 -
  40                 case MLO_AN_INBAND:
  41                         phylink_mac_pcs_get_state(pl, &link_state);
  42