git.openwrt.org Git - openwrt/staging/xback.git/blob

   1 From be1cc96ddf82bb0c0a159751f73239d6d3e9594a Mon Sep 17 00:00:00 2001
   2 From: Michael Klein <michael@fossekall.de>
   3 Date: Sun, 4 May 2025 19:29:15 +0200
   4 Subject: [PATCH] net: phy: realtek: use __set_bit() in
   5  rtl8211f_led_hw_control_get()
   6
   7 rtl8211f_led_hw_control_get() does not need atomic bit operations,
   8 replace set_bit() by __set_bit().
   9
  10 Signed-off-by: Michael Klein <michael@fossekall.de>
  11 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
  12 Link: https://patch.msgid.link/20250504172916.243185-6-michael@fossekall.de
  13 Signed-off-by: Paolo Abeni <pabeni@redhat.com>
  14 ---
  15  drivers/net/phy/realtek/realtek_main.c | 10 +++++-----
  16  1 file changed, 5 insertions(+), 5 deletions(-)
  17
  18 --- a/drivers/net/phy/realtek/realtek_main.c
  19 +++ b/drivers/net/phy/realtek/realtek_main.c
  20 @@ -659,17 +659,17 @@ static int rtl8211f_led_hw_control_get(s
  21         val &= RTL8211F_LEDCR_MASK;
  22
  23         if (val & RTL8211F_LEDCR_LINK_10)
  24 -               set_bit(TRIGGER_NETDEV_LINK_10, rules);
  25 +               __set_bit(TRIGGER_NETDEV_LINK_10, rules);
  26
  27         if (val & RTL8211F_LEDCR_LINK_100)
  28 -               set_bit(TRIGGER_NETDEV_LINK_100, rules);
  29 +               __set_bit(TRIGGER_NETDEV_LINK_100, rules);
  30
  31         if (val & RTL8211F_LEDCR_LINK_1000)
  32 -               set_bit(TRIGGER_NETDEV_LINK_1000, rules);
  33 +               __set_bit(TRIGGER_NETDEV_LINK_1000, rules);
  34
  35         if (val & RTL8211F_LEDCR_ACT_TXRX) {
  36 -               set_bit(TRIGGER_NETDEV_RX, rules);
  37 -               set_bit(TRIGGER_NETDEV_TX, rules);
  38 +               __set_bit(TRIGGER_NETDEV_RX, rules);
  39 +               __set_bit(TRIGGER_NETDEV_TX, rules);
  40         }
  41
  42         return 0;