projects / openwrt / staging / xback.git / blob
? search:


a4b6450e92d231042f8ddb3b12c330358db287db
[openwrt/staging/xback.git] /
1 From 708686132ba02659267c0cebcc414348ece389a5 Mon Sep 17 00:00:00 2001
2 From: Michael Klein <michael@fossekall.de>
3 Date: Sun, 4 May 2025 19:29:16 +0200
4 Subject: [PATCH] net: phy: realtek: Add support for PHY LEDs on RTL8211E
5
6 Like the RTL8211F, the RTL8211E PHY supports up to three LEDs.
7 Add netdev trigger support for them, too.
8
9 Signed-off-by: Michael Klein <michael@fossekall.de>
10 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
11 Link: https://patch.msgid.link/20250504172916.243185-7-michael@fossekall.de
12 Signed-off-by: Paolo Abeni <pabeni@redhat.com>
13 ---
14 drivers/net/phy/realtek/realtek_main.c | 125 +++++++++++++++++++++++--
15 1 file changed, 119 insertions(+), 6 deletions(-)
16
17 --- a/drivers/net/phy/realtek/realtek_main.c
18 +++ b/drivers/net/phy/realtek/realtek_main.c
19 @@ -40,6 +40,20 @@
20 #define RTL821x_PAGE_SELECT 0x1f
21 #define RTL821x_SET_EXT_PAGE 0x07
22
23 +/* RTL8211E extension page 44/0x2c */
24 +#define RTL8211E_LEDCR_EXT_PAGE 0x2c
25 +#define RTL8211E_LEDCR1 0x1a
26 +#define RTL8211E_LEDCR1_ACT_TXRX BIT(4)
27 +#define RTL8211E_LEDCR1_MASK BIT(4)
28 +#define RTL8211E_LEDCR1_SHIFT 1
29 +
30 +#define RTL8211E_LEDCR2 0x1c
31 +#define RTL8211E_LEDCR2_LINK_1000 BIT(2)
32 +#define RTL8211E_LEDCR2_LINK_100 BIT(1)
33 +#define RTL8211E_LEDCR2_LINK_10 BIT(0)
34 +#define RTL8211E_LEDCR2_MASK GENMASK(2, 0)
35 +#define RTL8211E_LEDCR2_SHIFT 4
36 +
37 /* RTL8211E extension page 164/0xa4 */
38 #define RTL8211E_RGMII_EXT_PAGE 0xa4
39 #define RTL8211E_RGMII_DELAY 0x1c
40 @@ -145,7 +159,8 @@
41 #define RTL_8221B_VN_CG 0x001cc84a
42 #define RTL_8251B 0x001cc862
43
44 -#define RTL8211F_LED_COUNT 3
45 +/* RTL8211E and RTL8211F support up to three LEDs */
46 +#define RTL8211x_LED_COUNT 3
47
48 MODULE_DESCRIPTION("Realtek PHY driver");
49 MODULE_AUTHOR("Johnson Leung");
50 @@ -169,6 +184,21 @@ static int rtl821x_write_page(struct phy
51 return __phy_write(phydev, RTL821x_PAGE_SELECT, page);
52 }
53
54 +static int rtl821x_read_ext_page(struct phy_device *phydev, u16 ext_page,
55 + u32 regnum)
56 +{
57 + int oldpage, ret = 0;
58 +
59 + oldpage = phy_select_page(phydev, RTL821x_SET_EXT_PAGE);
60 + if (oldpage >= 0) {
61 + ret = __phy_write(phydev, RTL821x_EXT_PAGE_SELECT, ext_page);
62 + if (ret == 0)
63 + ret = __phy_read(phydev, regnum);
64 + }
65 +
66 + return phy_restore_page(phydev, oldpage, ret);
67 +}
68 +
69 static int rtl821x_modify_ext_page(struct phy_device *phydev, u16 ext_page,
70 u32 regnum, u16 mask, u16 set)
71 {
72 @@ -608,7 +638,7 @@ static int rtl821x_resume(struct phy_dev
73 return 0;
74 }
75
76 -static int rtl8211f_led_hw_is_supported(struct phy_device *phydev, u8 index,
77 +static int rtl8211x_led_hw_is_supported(struct phy_device *phydev, u8 index,
78 unsigned long rules)
79 {
80 const unsigned long mask = BIT(TRIGGER_NETDEV_LINK_10) |
81 @@ -627,9 +657,11 @@ static int rtl8211f_led_hw_is_supported(
82 * rates and Active indication always at all three 10+100+1000
83 * link rates.
84 * This code currently uses mode B only.
85 + *
86 + * RTL8211E PHY LED has one mode, which works like RTL8211F mode B.
87 */
88
89 - if (index >= RTL8211F_LED_COUNT)
90 + if (index >= RTL8211x_LED_COUNT)
91 return -EINVAL;
92
93 /* Filter out any other unsupported triggers. */
94 @@ -648,7 +680,7 @@ static int rtl8211f_led_hw_control_get(s
95 {
96 int val;
97
98 - if (index >= RTL8211F_LED_COUNT)
99 + if (index >= RTL8211x_LED_COUNT)
100 return -EINVAL;
101
102 val = phy_read_paged(phydev, 0xd04, RTL8211F_LEDCR);
103 @@ -681,7 +713,7 @@ static int rtl8211f_led_hw_control_set(s
104 const u16 mask = RTL8211F_LEDCR_MASK << (RTL8211F_LEDCR_SHIFT * index);
105 u16 reg = 0;
106
107 - if (index >= RTL8211F_LED_COUNT)
108 + if (index >= RTL8211x_LED_COUNT)
109 return -EINVAL;
110
111 if (test_bit(TRIGGER_NETDEV_LINK_10, &rules))
112 @@ -704,6 +736,84 @@ static int rtl8211f_led_hw_control_set(s
113 return phy_modify_paged(phydev, 0xd04, RTL8211F_LEDCR, mask, reg);
114 }
115
116 +static int rtl8211e_led_hw_control_get(struct phy_device *phydev, u8 index,
117 + unsigned long *rules)
118 +{
119 + int ret;
120 + u16 cr1, cr2;
121 +
122 + if (index >= RTL8211x_LED_COUNT)
123 + return -EINVAL;
124 +
125 + ret = rtl821x_read_ext_page(phydev, RTL8211E_LEDCR_EXT_PAGE,
126 + RTL8211E_LEDCR1);
127 + if (ret < 0)
128 + return ret;
129 +
130 + cr1 = ret >> RTL8211E_LEDCR1_SHIFT * index;
131 + if (cr1 & RTL8211E_LEDCR1_ACT_TXRX) {
132 + __set_bit(TRIGGER_NETDEV_RX, rules);
133 + __set_bit(TRIGGER_NETDEV_TX, rules);
134 + }
135 +
136 + ret = rtl821x_read_ext_page(phydev, RTL8211E_LEDCR_EXT_PAGE,
137 + RTL8211E_LEDCR2);
138 + if (ret < 0)
139 + return ret;
140 +
141 + cr2 = ret >> RTL8211E_LEDCR2_SHIFT * index;
142 + if (cr2 & RTL8211E_LEDCR2_LINK_10)
143 + __set_bit(TRIGGER_NETDEV_LINK_10, rules);
144 +
145 + if (cr2 & RTL8211E_LEDCR2_LINK_100)
146 + __set_bit(TRIGGER_NETDEV_LINK_100, rules);
147 +
148 + if (cr2 & RTL8211E_LEDCR2_LINK_1000)
149 + __set_bit(TRIGGER_NETDEV_LINK_1000, rules);
150 +
151 + return ret;
152 +}
153 +
154 +static int rtl8211e_led_hw_control_set(struct phy_device *phydev, u8 index,
155 + unsigned long rules)
156 +{
157 + const u16 cr1mask =
158 + RTL8211E_LEDCR1_MASK << (RTL8211E_LEDCR1_SHIFT * index);
159 + const u16 cr2mask =
160 + RTL8211E_LEDCR2_MASK << (RTL8211E_LEDCR2_SHIFT * index);
161 + u16 cr1 = 0, cr2 = 0;
162 + int ret;
163 +
164 + if (index >= RTL8211x_LED_COUNT)
165 + return -EINVAL;
166 +
167 + if (test_bit(TRIGGER_NETDEV_RX, &rules) ||
168 + test_bit(TRIGGER_NETDEV_TX, &rules)) {
169 + cr1 |= RTL8211E_LEDCR1_ACT_TXRX;
170 + }
171 +
172 + cr1 <<= RTL8211E_LEDCR1_SHIFT * index;
173 + ret = rtl821x_modify_ext_page(phydev, RTL8211E_LEDCR_EXT_PAGE,
174 + RTL8211E_LEDCR1, cr1mask, cr1);
175 + if (ret < 0)
176 + return ret;
177 +
178 + if (test_bit(TRIGGER_NETDEV_LINK_10, &rules))
179 + cr2 |= RTL8211E_LEDCR2_LINK_10;
180 +
181 + if (test_bit(TRIGGER_NETDEV_LINK_100, &rules))
182 + cr2 |= RTL8211E_LEDCR2_LINK_100;
183 +
184 + if (test_bit(TRIGGER_NETDEV_LINK_1000, &rules))
185 + cr2 |= RTL8211E_LEDCR2_LINK_1000;
186 +
187 + cr2 <<= RTL8211E_LEDCR2_SHIFT * index;
188 + ret = rtl821x_modify_ext_page(phydev, RTL8211E_LEDCR_EXT_PAGE,
189 + RTL8211E_LEDCR2, cr2mask, cr2);
190 +
191 + return ret;
192 +}
193 +
194 static int rtl8211e_config_init(struct phy_device *phydev)
195 {
196 u16 val;
197 @@ -1479,6 +1589,9 @@ static struct phy_driver realtek_drvs[]
198 .resume = genphy_resume,
199 .read_page = rtl821x_read_page,
200 .write_page = rtl821x_write_page,
201 + .led_hw_is_supported = rtl8211x_led_hw_is_supported,
202 + .led_hw_control_get = rtl8211e_led_hw_control_get,
203 + .led_hw_control_set = rtl8211e_led_hw_control_set,
204 }, {
205 PHY_ID_MATCH_EXACT(0x001cc916),
206 .name = "RTL8211F Gigabit Ethernet",
207 @@ -1494,7 +1607,7 @@ static struct phy_driver realtek_drvs[]
208 .read_page = rtl821x_read_page,
209 .write_page = rtl821x_write_page,
210 .flags = PHY_ALWAYS_CALL_SUSPEND,
211 - .led_hw_is_supported = rtl8211f_led_hw_is_supported,
212 + .led_hw_is_supported = rtl8211x_led_hw_is_supported,
213 .led_hw_control_get = rtl8211f_led_hw_control_get,
214 .led_hw_control_set = rtl8211f_led_hw_control_set,
215 }, {
Staging tree of Koen Vandeputte