git.openwrt.org Git - openwrt/staging/nbd.git/blob

   1 From 24aaa42ed65c0811b598674a593fc653d643a7e6 Mon Sep 17 00:00:00 2001
   2 From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
   3 Date: Tue, 4 Feb 2025 16:35:49 +0100
   4 Subject: [PATCH] hwrng: rockchip - eliminate some unnecessary dereferences
   5
   6 Despite assigning a temporary variable the value of &pdev->dev early on
   7 in the probe function, the probe function then continues to use this
   8 construct when it could just use the local dev variable instead.
   9
  10 Simplify this by using the local dev variable directly.
  11
  12 Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
  13 Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  14 ---
  15  drivers/char/hw_random/rockchip-rng.c | 6 +++---
  16  1 file changed, 3 insertions(+), 3 deletions(-)
  17
  18 --- a/drivers/char/hw_random/rockchip-rng.c
  19 +++ b/drivers/char/hw_random/rockchip-rng.c
  20 @@ -148,7 +148,7 @@ static int rk_rng_probe(struct platform_
  21                 return dev_err_probe(dev, rk_rng->clk_num,
  22                                      "Failed to get clks property\n");
  23
  24 -       rst = devm_reset_control_array_get_exclusive(&pdev->dev);
  25 +       rst = devm_reset_control_array_get_exclusive(dev);
  26         if (IS_ERR(rst))
  27                 return dev_err_probe(dev, PTR_ERR(rst), "Failed to get reset property\n");
  28
  29 @@ -171,11 +171,11 @@ static int rk_rng_probe(struct platform_
  30         pm_runtime_use_autosuspend(dev);
  31         ret = devm_pm_runtime_enable(dev);
  32         if (ret)
  33 -               return dev_err_probe(&pdev->dev, ret, "Runtime pm activation failed.\n");
  34 +               return dev_err_probe(dev, ret, "Runtime pm activation failed.\n");
  35
  36         ret = devm_hwrng_register(dev, &rk_rng->rng);
  37         if (ret)
  38 -               return dev_err_probe(&pdev->dev, ret, "Failed to register Rockchip hwrng\n");
  39 +               return dev_err_probe(dev, ret, "Failed to register Rockchip hwrng\n");
  40
  41         return 0;
  42  }