git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 5c4cf36c538bb2714e43654e365cb77b19c4a93e Mon Sep 17 00:00:00 2001
   2 From: Chen Ni <nichen@iscas.ac.cn>
   3 Date: Mon, 24 Mar 2025 15:59:10 +0800
   4 Subject: [PATCH] wifi: rtw88: sdio: Remove redundant 'flush_workqueue()' calls
   5
   6 'destroy_workqueue()' already drains the queue before destroying it, so
   7 there is no need to flush it explicitly.
   8
   9 Remove the redundant 'flush_workqueue()' calls.
  10
  11 This was generated with coccinelle:
  12
  13 @@
  14 expression E;
  15 @@
  16
  17 - flush_workqueue(E);
  18   destroy_workqueue(E);
  19
  20 Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
  21 Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
  22 Link: https://patch.msgid.link/20250324075910.407999-1-nichen@iscas.ac.cn
  23 ---
  24  drivers/net/wireless/realtek/rtw88/sdio.c | 1 -
  25  1 file changed, 1 deletion(-)
  26
  27 --- a/drivers/net/wireless/realtek/rtw88/sdio.c
  28 +++ b/drivers/net/wireless/realtek/rtw88/sdio.c
  29 @@ -1298,7 +1298,6 @@ static void rtw_sdio_deinit_tx(struct rt
  30         struct rtw_sdio *rtwsdio = (struct rtw_sdio *)rtwdev->priv;
  31         int i;
  32
  33 -       flush_workqueue(rtwsdio->txwq);
  34         destroy_workqueue(rtwsdio->txwq);
  35         kfree(rtwsdio->tx_handler_data);
  36