git.openwrt.org Git - openwrt/staging/blocktrron.git/blob

   1 From 0c9d2d2ef0d916b490a9222ed20ff4616fca876d Mon Sep 17 00:00:00 2001
   2 From: Lorenzo Bianconi <lorenzo@kernel.org>
   3 Date: Wed, 8 Jan 2025 10:50:42 +0100
   4 Subject: [PATCH 3/6] PCI: mediatek-gen3: Add comment about initialization
   5  order in mtk_pcie_en7581_power_up()
   6 MIME-Version: 1.0
   7 Content-Type: text/plain; charset=UTF-8
   8 Content-Transfer-Encoding: 8bit
   9
  10 Add a comment in mtk_pcie_en7581_power_up() to clarify, unlike the other
  11 MediaTek Gen3 controllers, the Airoha EN7581 requires PHY initialization
  12 and power-on before PHY reset deassert.
  13
  14 Link: https://lore.kernel.org/r/20250108-pcie-en7581-fixes-v6-3-21ac939a3b9b@kernel.org
  15 Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
  16 Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
  17 Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
  18 Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
  19 ---
  20  drivers/pci/controller/pcie-mediatek-gen3.c | 4 ++++
  21  1 file changed, 4 insertions(+)
  22
  23 --- a/drivers/pci/controller/pcie-mediatek-gen3.c
  24 +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
  25 @@ -887,6 +887,10 @@ static int mtk_pcie_en7581_power_up(stru
  26         /* Wait for the time needed to complete the reset lines assert. */
  27         mdelay(PCIE_EN7581_RESET_TIME_MS);
  28
  29 +       /*
  30 +        * Unlike the other MediaTek Gen3 controllers, the Airoha EN7581
  31 +        * requires PHY initialization and power-on before PHY reset deassert.
  32 +        */
  33         err = phy_init(pcie->phy);
  34         if (err) {
  35                 dev_err(dev, "failed to initialize PHY\n");