git.openwrt.org Git - openwrt/staging/blocktrron.git/blob

   1 From 4229c28323db141eda69cb99427be75d3edba071 Mon Sep 17 00:00:00 2001
   2 From: Gabor Juhos <j4g8y7@gmail.com>
   3 Date: Wed, 14 May 2025 21:18:38 +0200
   4 Subject: [PATCH 7/7] pinctrl: armada-37xx: propagate error from
   5  armada_37xx_pmx_set_by_name()
   6
   7 The regmap_update_bits() function can fail, so propagate its error
   8 up to the stack instead of silently ignoring that.
   9
  10 Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
  11 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
  12 Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
  13 Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-7-07e9ac1ab737@gmail.com
  14 Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  15 ---
  16  drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 +---
  17  1 file changed, 1 insertion(+), 3 deletions(-)
  18
  19 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
  20 +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
  21 @@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(s
  22
  23         val = grp->val[func];
  24
  25 -       regmap_update_bits(info->regmap, reg, mask, val);
  26 -
  27 -       return 0;
  28 +       return regmap_update_bits(info->regmap, reg, mask, val);
  29  }
  30
  31  static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,