git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 76a6fc5644b2a1c70868bec24a078f784600ef2a Mon Sep 17 00:00:00 2001
   2 From: Dan Carpenter <dan.carpenter@linaro.org>
   3 Date: Wed, 24 Apr 2024 14:40:11 +0300
   4 Subject: [PATCH] cpufreq: sun50i: fix error returns in dt_has_supported_hw()
   5
   6 The dt_has_supported_hw() function returns type bool.  That means these
   7 negative error codes are cast to true but the function should return
   8 false instead.
   9
  10 Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw")
  11 Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
  12 Reviewed-by: Andre Przywara <andre.przywara@arm.com>
  13 Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
  14 Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
  15 ---
  16  drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++--
  17  1 file changed, 2 insertions(+), 2 deletions(-)
  18
  19 --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
  20 +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
  21 @@ -136,11 +136,11 @@ static bool dt_has_supported_hw(void)
  22
  23         cpu_dev = get_cpu_device(0);
  24         if (!cpu_dev)
  25 -               return -ENODEV;
  26 +               return false;
  27
  28         np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
  29         if (!np)
  30 -               return -ENOENT;
  31 +               return false;
  32
  33         for_each_child_of_node(np, opp) {
  34                 if (of_find_property(opp, "opp-supported-hw", NULL)) {