git.openwrt.org Git - openwrt/staging/pepe2k.git/blob

   1 From d450cdd9c4398add1f2aa7200f2c95f1e3b9f9fa Mon Sep 17 00:00:00 2001
   2 From: Gabor Juhos <j4g8y7@gmail.com>
   3 Date: Thu, 13 Mar 2025 19:31:21 +0100
   4 Subject: [PATCH] spi: spi-qpic-snand: avoid memleak in
   5  qcom_spi_ecc_init_ctx_pipelined()
   6
   7 When the allocation of the OOB buffer fails, the
   8 qcom_spi_ecc_init_ctx_pipelined() function returns without freeing
   9 the memory allocated for 'ecc_cfg' thus it can cause a memory leak.
  10
  11 Call kfree() to free 'ecc_cfg' before returning from the function
  12 to avoid that.
  13
  14 Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
  15 Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
  16 Link: https://patch.msgid.link/20250313-qpic-snand-memleak-fix-v1-1-e54e78d1da3a@gmail.com
  17 Signed-off-by: Mark Brown <broonie@kernel.org>
  18 ---
  19  drivers/spi/spi-qpic-snand.c | 4 +++-
  20  1 file changed, 3 insertions(+), 1 deletion(-)
  21
  22 --- a/drivers/spi/spi-qpic-snand.c
  23 +++ b/drivers/spi/spi-qpic-snand.c
  24 @@ -263,8 +263,10 @@ static int qcom_spi_ecc_init_ctx_pipelin
  25                 return -ENOMEM;
  26         snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize,
  27                                         GFP_KERNEL);
  28 -       if (!snandc->qspi->oob_buf)
  29 +       if (!snandc->qspi->oob_buf) {
  30 +               kfree(ecc_cfg);
  31                 return -ENOMEM;
  32 +       }
  33
  34         memset(snandc->qspi->oob_buf, 0xff, mtd->writesize + mtd->oobsize);
  35