git.openwrt.org Git - openwrt/staging/nbd.git/blob

   1 From f94500eb7328b35f3d0927635b1aba26c85ea4b0 Mon Sep 17 00:00:00 2001
   2 From: Sebastian Reichel <sebastian.reichel@collabora.com>
   3 Date: Thu, 20 Feb 2025 19:58:11 +0100
   4 Subject: arm64: dts: rockchip: Add GPU power domain regulator dependency for
   5  RK3588
   6 MIME-Version: 1.0
   7 Content-Type: text/plain; charset=UTF-8
   8 Content-Transfer-Encoding: 8bit
   9
  10 Enabling the GPU power domain requires that the GPU regulator is
  11 enabled. The regulator is enabled at boot time, but gets disabled
  12 automatically when there are no users.
  13
  14 This means the system might run into a failure state hanging the
  15 whole system for the following use cases:
  16
  17  * if the GPU driver is being probed late (e.g. build as a
  18    module and firmware is not in initramfs), the regulator
  19    might already have been disabled. In that case the power
  20    domain is enabled before the regulator.
  21  * unbinding the GPU driver will disable the PM domain and
  22    the regulator. When the driver is bound again, the PM
  23    domain will be enabled before the regulator and error
  24    appears.
  25
  26 Avoid this by adding an explicit regulator dependency to the
  27 power domain.
  28
  29 Tested-by: Heiko Stuebner <heiko@sntech.de>
  30 Reported-by: Adrián Martínez Larumbe <adrian.larumbe@collabora.com>
  31 Tested-by: Adrian Larumbe <adrian.larumbe@collabora.com> # On Rock 5B
  32 Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
  33 Link: https://lore.kernel.org/r/20250220-rk3588-gpu-pwr-domain-regulator-v6-8-a4f9c24e5b81@kernel.org
  34 Signed-off-by: Heiko Stuebner <heiko@sntech.de>
  35
  36 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
  37 +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
  38 @@ -425,6 +425,10 @@
  39         status = "okay";
  40  };
  41
  42 +&pd_gpu {
  43 +       domain-supply = <&vdd_gpu_s0>;
  44 +};
  45 +
  46  &pinctrl {
  47         hym8563 {
  48                 hym8563_int: hym8563-int {