git.openwrt.org Git - openwrt/staging/pepe2k.git/blob

   1 From 4be5e698ba5f28037bbbee4cb4326d21a383ed06 Mon Sep 17 00:00:00 2001
   2 From: Dom Cobley <popcornmix@gmail.com>
   3 Date: Mon, 17 Jul 2023 17:45:32 +0100
   4 Subject: [PATCH 0634/1085] drm/vc4: kms: Avoid setting core and disp clocks
   5  for hdmi modes
   6
   7 On 2712, the firmware always runs these clock at a speed sufficient
   8 for dual 4kp60.
   9
  10 The requests here prevent the gpu from going into its lowest voltage
  11 mode, so just skip the clock requests.
  12
  13 With this applied the idle voltage on my pi 5 reduces from 0.7424V
  14 to 0.72V.
  15
  16 Signed-off-by: Dom Cobley <popcornmix@gmail.com>
  17 ---
  18  drivers/gpu/drm/vc4/vc4_kms.c | 4 ++--
  19  1 file changed, 2 insertions(+), 2 deletions(-)
  20
  21 --- a/drivers/gpu/drm/vc4/vc4_kms.c
  22 +++ b/drivers/gpu/drm/vc4/vc4_kms.c
  23 @@ -429,7 +429,7 @@ static void vc4_atomic_commit_tail(struc
  24                 old_hvs_state->fifo_state[channel].pending_commit = NULL;
  25         }
  26
  27 -       if (vc4->gen >= VC4_GEN_5 && !vc4->firmware_kms) {
  28 +       if (vc4->gen == VC4_GEN_5 && !vc4->firmware_kms) {
  29                 unsigned long state_rate = max(old_hvs_state->core_clock_rate,
  30                                                new_hvs_state->core_clock_rate);
  31                 unsigned long core_rate = clamp_t(unsigned long, state_rate,
  32 @@ -483,7 +483,7 @@ static void vc4_atomic_commit_tail(struc
  33
  34         drm_atomic_helper_cleanup_planes(dev, state);
  35
  36 -       if (vc4->gen >= VC4_GEN_5 && !vc4->firmware_kms) {
  37 +       if (vc4->gen == VC4_GEN_5 && !vc4->firmware_kms) {
  38                 unsigned long core_rate = min_t(unsigned long,
  39                                                 hvs->max_core_rate,
  40                                                 new_hvs_state->core_clock_rate);